Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround pysankey issue and enhanced button for next question #120

Merged
merged 6 commits into from
Jan 24, 2021

Conversation

gjelsas
Copy link

@gjelsas gjelsas commented Jan 23, 2021

#I added a workaround for the pySankey != pysankey import error and added some code for the differentiation between the next question and the last question which closes the survey. For issue #117 and #58

@gjelsas
Copy link
Author

gjelsas commented Jan 23, 2021

Update for the German translation.

Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for that ! I just have a minor question regarding the problem with sankey.

survey/exporter/tex/question2tex_sankey.py Show resolved Hide resolved
gjelsas and others added 2 commits January 24, 2021 00:03
@Pierre-Sassoulas
Copy link
Owner

Thank you for the contribution, I'm going to release a new version with those changes shortly.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 51ef2e2 into Pierre-Sassoulas:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants